Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Use enum class instead of struct #496

Merged
merged 3 commits into from
Oct 5, 2019
Merged

Use enum class instead of struct #496

merged 3 commits into from
Oct 5, 2019

Conversation

primenumber
Copy link
Contributor

@primenumber primenumber commented Oct 4, 2019 •
edited
Loading

Replace from struct de10_nano::Csr to enum class.
close #489 .

Motivation and Context

de10_nano::Csr contain just compile time constants.
That can be replaced by enum.

Description

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature / Optimization (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@primenumber primenumber self-assigned this Oct 4, 2019
@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Oct 4, 2019
@tkng tkng self-requested a review October 4, 2019 12:24
tkng
tkng approved these changes Oct 5, 2019
View reviewed changes
Copy link
Contributor

@tkng tkng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tkng tkng merged commit 463fc29 into blue-oil:master Oct 5, 2019
kchygoe added a commit that referenced this pull request Oct 7, 2019
@kchygoe
Revert "Use enum class instead of struct (#496)"
a0ed9f4 
This reverts commit 463fc29.
@iizukak iizukak added this to the v0.12.0 milestone Oct 10, 2019
@primenumber primenumber deleted the feature/use-enum branch March 24, 2020 16:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tkng tkng tkng approved these changes

Assignees

@primenumber primenumber

Labels
CI: auto-run Run CI automatically
Projects
None yet
Milestone
v0.12.0
Development

Successfully merging this pull request may close these issues.

Use enum class instead of struct for de10_nano::Csr
3 participants
@primenumber @tkng @iizukak